Add missing ES6 rules to ESLint config. #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,8 @@ module.exports = { | |||
| 'jsx': true | |||
| }, | |||
| 'rules': { | |||
| // enforces no braces where they can be omitted | |||
| 'arrow-body-style': [2, 'as-needed'], | |||
There was a problem hiding this comment.
could we link to http://eslint.org/docs/rules/arrow-body-style in a comment?
|
Thanks, this looks great pending 2 comments :-) |
`arrow-body-style` (8.2) and `prefer-template` (6.4) are described in the Style Guide.
|
I've added the links. Right now the linting for eslint-config-airbnb shows 148 errors. Would you accept a PR which fixes those? |
|
Thanks! i'm not sure what linting you're talking about though. |
|
Running |
|
good lord, why isn't that being run as part of tests?? thanks, i'll fix that right now |
ljharb
added a commit
that referenced
this pull request
Jan 16, 2016
|
Thanks, fixed in ab58d3b |
gilbox
pushed a commit
to gilbox/javascript
that referenced
this pull request
Mar 21, 2016
jaylaw81
pushed a commit
to appirio-digital/ads-best-practices
that referenced
this pull request
Sep 19, 2017
sensiblegame
added a commit
to sensiblegame/React-BNB
that referenced
this pull request
Oct 23, 2017
MK825
added a commit
to MK825/javascript
that referenced
this pull request
Jan 27, 2023
Binary-Ninja-007
added a commit
to Binary-Ninja-007/JavaScript_Style_Guide
that referenced
this pull request
Aug 13, 2023
harry908nilson
pushed a commit
to marcolane/Javascriipt
that referenced
this pull request
Sep 1, 2023
talentdev219
pushed a commit
to talentdev219/javascript
that referenced
this pull request
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrow-body-style(8.2) andprefer-template(6.4) are described inthe Style Guide.