fix: Updated grammatical errors on LICENSE.md #2774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note that the changes made primarily involve the placement of commas to enhance readability and clarify the intended meaning of the sentence.
ljharb
requested changes
May 21, 2023
| @@ -4,7 +4,7 @@ Copyright (c) 2012 Airbnb | |||
|
|
|||
| Permission is hereby granted, free of charge, to any person obtaining a copy | |||
| of this software and associated documentation files (the "Software"), to deal | |||
| in the Software without restriction, including without limitation the rights | |||
| in the Software without restriction, including, without limitation, the rights | |||
There was a problem hiding this comment.
these commas are absent in the canonically recognized version of the MIT license, so i think it's best not to add them.
There was a problem hiding this comment.
I think a comma alone would not likely invalidate the MIT License or change its fundamental nature.
There was a problem hiding this comment.
I agree, but it might make static license detection difficult.
amantank
approved these changes
May 21, 2023
| @@ -4,7 +4,7 @@ Copyright (c) 2012 Airbnb | |||
|
|
|||
| Permission is hereby granted, free of charge, to any person obtaining a copy | |||
| of this software and associated documentation files (the "Software"), to deal | |||
| in the Software without restriction, including without limitation the rights | |||
| in the Software without restriction, including, without limitation, the rights | |||
There was a problem hiding this comment.
I think a comma alone would not likely invalidate the MIT License or change its fundamental nature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made primarily involve the placement of commas to enhance readability and clarify the intended meaning of the sentence.