Update minimum deployment target to iOS 13.0 / macOS 10.15 #2322
+20
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynbodayle
approved these changes
Feb 21, 2024
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 8, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch | `from: "4.4.1"` -> `from: "4.4.2"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.4.2`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.2) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.1...4.4.2) ##### Changes in 4.4.2 - Update minimum deployment target to iOS 13.0 / macOS 10.15 ([airbnb/lottie-ios#2322) - Add privacy manifest to lottie-spm repo ([airbnb/lottie-spm#23) - Add visionOS support to Cocoapods podspec ([airbnb/lottie-ios#2348) - Fix incorrect usage of `State(initialValue:)` in `LottieView` ([airbnb/lottie-ios#2357) - Use correct version number when building XCFramework bundle ([airbnb/lottie-ios#2341) ##### New features in 4.4.0 - Add privacy manifest ([airbnb/lottie-ios#2252) - Codesign Lottie.xcframework ([airbnb/lottie-ios#2259) - Add time remapping support to Core Animation rendering engine ([airbnb/lottie-ios#2286) - Add official visionOS support to lottie-ios repo ([airbnb/lottie-ios#2287) - lottie-spm now supports visionOS ([airbnb/lottie-spm#12) - Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 ([airbnb/lottie-ios#2260) **Full Changelog**: airbnb/lottie-ios@4.4.1...4.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
|
It feels super weird having this bump to iOS 13 in a patch release. Honestly, I would recommend a major upgrade for this since you're essentially breaking compatibility. I still support iOS 12 and now I can't get any bug fixes from 4.4.3 or later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Lottie's minimum deployment target to iOS 13.0 / macOS 10.15.
Our current deployment target is iOS 11.0. Xcode emits this warning when we build the project:
It seems like a good idea to fix that by at least updating to iOS 12.0+.
iOS 13 seems like a good minimum for us because:
async/await, which we use heavily, and currently results in a lot of@availableannotationsI'll release a new version with all of the existing changes on master before merging this change.
Any consumer with a deployment target lower than iOS 13.0 will still be able to use Lottie 4.4.1 and earlier.