Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorect InitialValue Usage in SwiftUI Wrapper #2357

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

brynbodayle
Copy link
Contributor

  • Fixes an issue where someone is unable to update a LottieView's animation in SwiftUI due to internal usage of the State(initialValue:) initializer which only is run once
  • Fixes for new Xcode version concurrency warnings

Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, thanks!

@calda calda enabled auto-merge (squash) April 2, 2024 20:37
@calda calda merged commit 8a784b2 into airbnb:master Apr 2, 2024
13 checks passed
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 8, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.4.1"` -> `from: "4.4.2"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.4.2`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.2)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.1...4.4.2)

##### Changes in 4.4.2

- Update minimum deployment target to iOS 13.0 / macOS 10.15
([airbnb/lottie-ios#2322)
- Add privacy manifest to lottie-spm repo
([airbnb/lottie-spm#23)
- Add visionOS support to Cocoapods podspec
([airbnb/lottie-ios#2348)
- Fix incorrect usage of `State(initialValue:)` in `LottieView`
([airbnb/lottie-ios#2357)
- Use correct version number when building XCFramework bundle
([airbnb/lottie-ios#2341)

##### New features in 4.4.0

- Add privacy manifest
([airbnb/lottie-ios#2252)
- Codesign Lottie.xcframework
([airbnb/lottie-ios#2259)
- Add time remapping support to Core Animation rendering engine
([airbnb/lottie-ios#2286)
- Add official visionOS support to lottie-ios repo
([airbnb/lottie-ios#2287)
- lottie-spm now supports visionOS
([airbnb/lottie-spm#12)
- Adopt policy on minimum supported Swift / Xcode version, update
minimum versions to Swift 5.7 / Xcode 14.1
([airbnb/lottie-ios#2260)

**Full Changelog**:
airbnb/lottie-ios@4.4.1...4.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants