Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook enhancements #32

Open
stefhatcher opened this issue Apr 17, 2019 · 7 comments
Open

Storybook enhancements #32

stefhatcher opened this issue Apr 17, 2019 · 7 comments

Comments

@stefhatcher
Copy link
Contributor

after switching to storybook 5, would be nice to have/look into:

@milesj
Copy link
Contributor

milesj commented Apr 17, 2019

  1. I tried the info addon and it wasn't great at all. That's why I built a custom props panel. Also looked into the readme addon but it's geared towards Vue and adding README files for every component is overkill.

  2. Sadly live-edit isn't v5 compatible.

  3. Code block may be possible? The issue is that all code examples are in a story TS file, which isn't easily parsable to extract the specific "blocks".

@stefhatcher
Copy link
Contributor Author

adding README files for every component is overkill.

especially since they were just converted during the migration to storybook 🤣

@Alphy11
Copy link
Contributor

Alphy11 commented Apr 19, 2019

As a user of it, the code of how you generated the story is 80% of why I used the styleguideist before. It was far easier to figure out proper usage, especially for components that require specific children.

Also, the colors being in styleguide made it a really nice go-to when I was trying to convert designs into code in my head.

@milesj
Copy link
Contributor

milesj commented Apr 24, 2019

Added view source/story links. Looking into adding some design system stories.

@stefhatcher
Copy link
Contributor Author

Looking into adding some design system stories.

some design system stories around colors and patterns, e.g. box shadow and button reset, would be great!

@jpdanks
Copy link

jpdanks commented May 9, 2019

Any updates on adding design system info? need anything from us? @stefhatcher @milesj ?

@milesj
Copy link
Contributor

milesj commented May 9, 2019

@jpdanks Time? :P

@milesj milesj changed the title storybook enhancements Storybook enhancements Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants