-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZK connectivity failure with multiple watchers leads to permanent failure #92
Comments
@minkovich what is your desired behavior here? I suppose that we would like it if Nerve threw out the bad cached connection and tried again? If the cluster is just not reachable this would lead to a similar infinite retry loop, but perhaps crash-recover is sufficient here? |
@jolynch The efficient solution would be for nerve to throw away the bad connection, but honestly in this situation a crash recovery would also be equivalent since connectivity was already lost. |
Closed because this was fixed in #113. |
Setup:
6 nerve service watchers on the same instance connected to the same ZK pool
How to reproduce:
Nerve::Nerve: nerve: watcher service1 not alive; reaping and relaunching
Nerve::ServiceWatcher: nerve: stopping service watch service1
Nerve::Nerve: nerve: could not reap service1, got #<Zookeeper::Exceptions::NotConnected: Zookeeper::Exceptions::NotConnected>
Actual problem:
The problem is that in start() in zookeeper.rb there are no checks to see if the ZK connection is alive before re-using in.
The text was updated successfully, but these errors were encountered: