Fixing #58 - Check if there are any test variants when plugin is applied #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
approved these changes
Nov 28, 2017
|
Thanks @premnirmal ! |
|
awesome! |
|
Thank you for merging this. When do you estimate this to be live on maven central? |
|
I'll cut v1.4.0 today or tomorrow. you can use 1.4.0-SNAPSHOT in the meantime |
|
Thanks, still waiting for the release version |
|
v1.4.0 is now live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build error specified in #58.
When the application variant is not a test variant, the list
(androidConfig as TestedExtension).testVariantsis empty, and should not be used to get the test application ID.This PR checks to see if the list is not empty before calling
(androidConfig as TestedExtension).testVariants.first()in the ok replay plugin.