Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for caches and rest client #37

Merged
merged 1 commit into from
Jan 23, 2018
Merged

add tests for caches and rest client #37

merged 1 commit into from
Jan 23, 2018

Conversation

danfrankj
Copy link
Collaborator

@danfrankj danfrankj commented Jan 22, 2018 •
edited
Loading

Summary

Full integration tests for local cache backed by pyfakefs
Test that restclient manages to call requests

Reviewers

@matthewwardrop

matthewwardrop
matthewwardrop approved these changes Jan 23, 2018
View reviewed changes
Copy link
Collaborator

@matthewwardrop matthewwardrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First tests! Hurrah! Thanks @danfrankj .

@matthewwardrop matthewwardrop merged commit d13649d into master Jan 23, 2018
@matthewwardrop matthewwardrop deleted the df_add_tests branch January 26, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwardrop matthewwardrop matthewwardrop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danfrankj @matthewwardrop