Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to KotlinPoet 1.0.0 #88

Merged
merged 2 commits into from
Jan 2, 2019

Conversation

ShaishavGandhi
Copy link
Contributor

As part of moving Epoxy to KotlinPoet 1.0.0-RC3, we had a build failure there which seemed to be because Paris uses an old version of KotlinPoet. This upgrades it to the latest RC.

@ShaishavGandhi
Copy link
Contributor Author

Oops noticed that there is another PR that updates KotlinPoet. Let me know if you want this around or you'll proceed with the other one.

@ShaishavGandhi
Copy link
Contributor Author

KotlinPoet 1.0.0 has released. Have updated the PR.

@ShaishavGandhi ShaishavGandhi changed the title Move to KotlinPoet 1.0.0-RC3 Move to KotlinPoet 1.0.0 Dec 11, 2018
@filipwiech
Copy link

KotlinPoet 1.0.1 has been released just a little while ago, perhaps you can update this pull request before merging. :)

Copy link
Collaborator

@ngsilverman ngsilverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ngsilverman ngsilverman merged commit c60c100 into airbnb:master Jan 2, 2019
@ShaishavGandhi ShaishavGandhi deleted the sg/kotlinpoet-130-RC3 branch January 3, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants