Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] add Ukrainian #184

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[New] add Ukrainian #184

merged 1 commit into from
Jul 11, 2024

Conversation

olegfedak
Copy link
Contributor

I work with Decap CMS, which runs with node-polyglot. I've noticed that Ukrainian pluralization is incorrect. So, I really need this update! -_-

ljharb
ljharb requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need tests.

@ljharb ljharb marked this pull request as draft July 11, 2024 05:41
@olegfedak olegfedak requested a review from ljharb July 11, 2024 12:36
@olegfedak olegfedak marked this pull request as ready for review July 11, 2024 12:59
@olegfedak
Copy link
Contributor Author

@ljharb what sort of tests bisides pretest an test should I run?

@ljharb
Copy link
Collaborator

ljharb commented Jul 11, 2024

I think you misunderstood; your PR will need to add tests for Ukrainian.

ljharb
ljharb reviewed Jul 11, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
@ljharb ljharb marked this pull request as draft July 11, 2024 15:19
@ljharb ljharb marked this pull request as ready for review July 11, 2024 21:35
ljharb
ljharb approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ljharb ljharb merged commit 2e29439 into airbnb:master Jul 11, 2024
37 checks passed
@olegfedak olegfedak mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegfedak @ljharb