For for Issue #713 Unavailable Date phrase not reading on Screen Readers #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for existence of the BLOCKED_MODIFIER now that modifiers is a Set and no longer an object.
majapw
reviewed
Oct 13, 2017
majapw
approved these changes
Oct 13, 2017
|
No problem, I'm happy I was able to find it! This was one of those sneaky bugs where for the case of available dates it was coincidentally working fine, where the check for the blocking modifier was returning false, it just happened to be for the wrong reason. So it's easy to see how it was able to fly under the radar. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #713 by updating the way in which modifiers is checked for existence of the BLOCKED_MODIFIER now that modifiers is a Set and no longer an object.