Fixes React 16 prop-type Errors #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 31, 2018
|
I can give it a shot - been having a hard time getting these tests to run, especially on Windows. Will report back soon. |
|
Finally got things going with a VM. Added a test for the warning and validation of the branching logic. Let me know if it was too much or if you were looking for something more. |
|
Great, finally we can get rid of the annoying warnings 👍 |
|
Excellent work on the PR. Hope this sees the light of day soon :) |
ljharb
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the component is started in a React 16 environment and the
disabledprop is set to true, React 16 will throw a console warning for each of the functions set via the short circuit logical operators.This currently manifests as the following (subset) of warnings logged as console errors:
This PR acts to silence those warnings and prep for the anticipation that React 17 will convert these to throwable errors. Documentation of the changes that introduced these warnings can be found here under "Non-boolean attributes with boolean values"