Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY's out some code #1164

Merged
merged 2 commits into from
Mar 31, 2020
Merged

DRY's out some code #1164

merged 2 commits into from
Mar 31, 2020

Conversation

Ryxias
Copy link
Contributor

@Ryxias Ryxias commented Feb 24, 2020

to: @ryandeivert
cc: @airbnb/streamalert-maintainers

@Ryxias Ryxias changed the base branch from master to release-3-1-0 February 24, 2020 20:46
@Ryxias Ryxias added this to the 3.1.0 milestone Feb 24, 2020
@coveralls
Copy link

coveralls commented Feb 24, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 95.385% when pulling 2bc4340 on dw--bug into 5b63c95 on release-3-1-1.

@ryandeivert
Copy link
Contributor

@Ryxias is this still applicable? do you want to touch up and merge?

@ryandeivert ryandeivert modified the milestones: 3.1.0, 3.2.0 Mar 27, 2020
@ryandeivert ryandeivert changed the base branch from release-3-1-0 to master March 28, 2020 01:32
@Ryxias Ryxias changed the base branch from master to release-3-1-1 March 31, 2020 18:58
@Ryxias Ryxias modified the milestones: 3.2.0, 3.1.1 Mar 31, 2020
@Ryxias Ryxias merged commit 8fccc53 into release-3-1-1 Mar 31, 2020
@Ryxias Ryxias deleted the dw--bug branch March 31, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandeivert ryandeivert ryandeivert approved these changes

Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryxias @coveralls @ryandeivert