Normalization reboot - Add condition support to normalizer #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryxias
approved these changes
May 5, 2020
streamalert/shared/normalize.py
Outdated
| found_value = False | ||
| break | ||
| found_value = True | ||
| if param.get('condition') and not cls._match_condition(record, param['condition']): |
There was a problem hiding this comment.
condition —> CONST_CONDITION?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @airbnb/streamalert-maintainers
related to: #1178, #1230, #1238, #1237, #1242
resolves:
Background
This PR is to add the optional block
conditionto normalization configure. With this support, we will have more flexibility to normalize only a subset of data. The normalizer will be skipped if theconditionblock presented and the condition is not met.See the updated doc for the usage of the
conditionblock.Changes
2.48.0to avoid the bug Unable to remove aws_kinesis_firehose_delivery_stream S3 processorsconditionblock supportTesting