Marathon Watcher #87
Closed
Marathon Watcher #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 11, 2014 11:26
Pull service information from Marathon's task API to allow using it for service discovery.
|
hey thanks for the PR. i'm going have a chance to look through this and other PRs when i get back from vacation in september. |
Now checks for errors from the Marathon client and logs them.
|
Any update on this? |
|
Here's another series of commits that I needed to get this working w/ marathon 0.7.3 https://github.com/acmcelwee/synapse/commits/marathon. Unfortunately, those are also blocked until 0.3.0 of the marathon_client is published to rubygems.org, issue #14 over there. For now, I've hacked in the updated marathon_client in my env, and that, plus the commits referenced above got me all set w/ this new watcher. |
Merged
|
+1 for this functionality. I accidentally implemented the same thing earlier today in #101. Anyway, merging one of these would be awesome. |
|
Merged #101 which should cover this functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a service watcher that uses data from the Marathon REST API V2 to locate services. It's based on a combination of the Docker and EC2 watchers.