Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing resize-observer-polyfill #1325

Closed
gbiryukov opened this issue Aug 25, 2021 · 0 comments · Fixed by #1422
Closed

Consider replacing resize-observer-polyfill #1325

gbiryukov opened this issue Aug 25, 2021 · 0 comments · Fixed by #1422
Labels
🤖 typescript

Comments

@gbiryukov
Copy link

gbiryukov commented Aug 25, 2021 •
edited
Loading

@visx/responsive and some other @visx packages are using resize-observer-polyfill which is not compatible with typescript starting from 4.2.3 and was not updated in over 3 years so seems it will never be fixed.

Having this dependency breaks end users projects typecheck after updating to typescript >=4.2.3

Possible alternative is @juggle/resize-observer which is purely written in typescript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: replace resize-observer-polyfill with @juggle/resize-observer airbnb/visx
2 participants
@williaster @gbiryukov