-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(responsive): remove ResizeObserver type declaration #1253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I think the type is still referenced locally which is failing the build tho.
Hmm. I guess this won't work unless we upgrade Typescript to 4? |
Oof, I guess maybe not 😞 I think we can get TS 4 working with nimbus, so maybe can give it a go. |
@williaster Is there anything we can do to have this merged? |
Hey @HHK1 unfortunately we can't easily upgrade the project to TS 4 because we have a layer of abstraction on top of our dev infra which is still at TS 3. I created this issue to track, this is a big priority/on our radar for 2022 (I created #1421 to track). I guess one alternative is to add |
Superseded by #1423 |
🐛 Bug Fix
Fix #1104