Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(responsive): remove ResizeObserver type declaration #1253

Closed
wants to merge 4 commits into from

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Jun 25, 2021

🐛 Bug Fix

Fix #1104

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I think the type is still referenced locally which is failing the build tho.

@kristw
Copy link
Collaborator Author

kristw commented Jun 25, 2021

Hmm. I guess this won't work unless we upgrade Typescript to 4?

@williaster
Copy link
Collaborator

Oof, I guess maybe not 😞 I think we can get TS 4 working with nimbus, so maybe can give it a go.

@HHK1
Copy link

HHK1 commented Jan 4, 2022

@williaster Is there anything we can do to have this merged?
I'm trying to update to typescript 4.2.3+ and I'm running into compile issues.
All of the following issues are linked to the update of the DOM lib types definition update: #1325, que-etc/resize-observer-polyfill#83 and #1104

@williaster
Copy link
Collaborator

williaster commented Jan 20, 2022

Hey @HHK1 unfortunately we can't easily upgrade the project to TS 4 because we have a layer of abstraction on top of our dev infra which is still at TS 3. I created this issue to track, this is a big priority/on our radar for 2022 (I created #1421 to track).

I guess one alternative is to add @ts-expect-error directives to the couple of instances that throw with these changes. @kristw @gazcn007 any thoughts on that?

@williaster
Copy link
Collaborator

Superseded by #1423

@williaster williaster closed this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove global type declaration of ResizeObserver in the visx-responsive package
3 participants