Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(xychart): add colorAccessor to relevant series #1005

Merged
merged 8 commits into from
Jan 11, 2021

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

📝 Documentation

This closes #996 and adds the ability to override color via colorAccessor to the following series that should feasibly support per-datum colors (you can already override colors for Line/AreaSeries)

  • BarSeries
  • GlyphSeries
  • BarStack
  • BarGroup

It also

  • adds tests for new functionality
  • updates the /xychart demo to show this functionality (annotated datum gets a pattern color)
  • updates AnimatedGlyph/Bars to handle url(#...) based colors (hadn't tested this before and react-spring chokes on them; have a solution that looks okay tho)

@hshoff

@coveralls
Copy link

Pull Request Test Coverage Report for Build 472664628

  • 10 of 11 (90.91%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.33%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-xychart/src/components/series/private/AnimatedGlyphs.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 466988844: 0.1%
Covered Lines: 1735
Relevant Lines: 2697

💛 - Coveralls

@williaster williaster merged commit ad43f17 into master Jan 11, 2021
@williaster williaster deleted the chris--xychart-color-accessor branch January 11, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request(xychart): add color accessors to all series
3 participants