fix(vx-brush): Fix initialBrushPosition #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
May 2, 2020
williaster
commented
May 2, 2020
| @@ -185,36 +177,33 @@ export default class BaseBrush extends React.Component<BaseBrushProps, BaseBrush | |||
| }; | |||
|
|
|||
| handleDragEnd = () => { | |||
| const { isBrushing } = this.state; | |||
| if (isBrushing) { | |||
There was a problem hiding this comment.
noting to document:
by the time this function is called state has been updated isBrushing usually has been updated to false and so this feature didn't work as intended.
|
CI passed even tho it's not posting here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This fixes some problems with the implementation of
initialBrushPositionfrom #618BrushStartEndexpected bothxandyofstart/endto be defined, which doesn't work if you have avertical-orhorizontal-only brush. Fixed to handle partials.state.start/endlogic which is used byBrushSelectionupon moving a selection.Before
After
Also updates the demo to include an
initialBrushPositionwhich should be useful for peeps🏠 Internal
Jest was failing locally to collect coverage due to a missing react component function name. I added one to fix locally, and see if it fixes anything on CI.
@hshoff @kristw
cc @maryschmidt