new(xychart): add (EventEmitter, Tooltip)Context + basic Tooltips #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 85
💛 - Coveralls |
kristw
approved these changes
Oct 1, 2020
| emitter.on<HandlerParams>(eventType, handler); | ||
| return () => emitter?.off<HandlerParams>(eventType, handler); | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
not necessary to return undefined?
There was a problem hiding this comment.
I get lint errors if I return nothing (not all paths return a value) and undefined was the only non-function return value allowed by TS
There was a problem hiding this comment.
oh right. ignore my comment then
packages/visx-xychart/src/utils/findNearestDatumSingleDimension.ts
Outdated
Show resolved
Hide resolved
williaster
force-pushed
the
chris--xychart-events
branch
from
55e440f
to
2b22494
Compare
8 tasks
* test(xychart): organize test/ into subfolders that mirror src/ * test(xychart): add EventEmitterProvider + TooltipProvider tests * test(xychart): add Tooltip test, add UseTooltipPortalOptions props * test(xychart): add useEventEmitter tests * test(xychart): add findNearestDatum tests * fix(xychart): test + type fixes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
🚀 Enhancements
This PR adds event + tooltip layers to the
xychartpackage, and updates the demo to use them. These layers were largely coupled in theXYChartproof-of-concept (#745) but I think it's cleaner to separate the two so that different events (brush, pan, zoom) can be supported later.The event emitter context layer is implemented based loosely on the proof-of-concept discussed in #761 (see sandbox), and the tooltip context mostly mirrors the
useTooltipfunctionality but provided in context instead of a hook.To explain how everything fits together I made this
Demo
Future work
@kristw @hshoff @techniq