Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump @types/d3-scale #856

Merged
merged 2 commits into from
Oct 8, 2020
Merged

build: bump @types/d3-scale #856

merged 2 commits into from
Oct 8, 2020

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Oct 7, 2020

🚀 Enhancements

  • bump @types/d3-scale

Fix #855

@coveralls
Copy link

coveralls commented Oct 8, 2020

Pull Request Test Coverage Report for Build 296238181

  • 9 of 13 (69.23%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.6%) to 57.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-stats/src/ViolinPlot.tsx 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
packages/visx-tooltip/src/hooks/useTooltip.ts 3 44.44%
packages/visx-xychart/src/components/Tooltip.tsx 3 82.96%
packages/visx-xychart/src/components/series/LineSeries.tsx 5 40.63%
packages/visx-tooltip/src/hooks/useTooltipInPortal.tsx 7 0%
Totals Coverage Status
Change from base Build 119: 0.6%
Covered Lines: 1285
Relevant Lines: 2172

💛 - Coveralls

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making all the fixes needed for this 🙏 lgtm. may have to figure out if this will count as a breaking change or not.

@kristw kristw merged commit 5bb42fc into airbnb:master Oct 8, 2020
@williaster williaster added this to the 1.1.0 milestone Oct 17, 2020
@razh
Copy link

razh commented Nov 11, 2020

Might be able to revert this? @types/d3-scale v3.2.1 no longer returns unknown values.

DefinitelyTyped/DefinitelyTyped#49196

@williaster
Copy link
Collaborator

@kristw wdyt?

@kristw
Copy link
Collaborator Author

kristw commented Nov 16, 2020

Might be able to revert this? @types/d3-scale v3.2.1 no longer returns unknown values.

DefinitelyTyped/DefinitelyTyped#49196

@razh Could you elaborate a bit more about your concerns with the unknown and why we should revert the change?

Also, things are a bit more complicated as the previous version of the types was for d3-scale 2 and mistyped a few things and did not include several functions that are available API. I would prefer to have types that better match the d3-scale to avoid mistakes in the library.

@razh
Copy link

razh commented Nov 17, 2020

It's mostly a matter of correctness versus convenience.

Given a known domain and range, scaleLinear/scaleTime/etc. should not return undefined.

This comment explains the rationale:

DefinitelyTyped/DefinitelyTyped#48299 (comment)

I don't have a stake in the game here, just FYI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d3-scale out of sync with typings
4 participants