Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(xychart): add BarStack tests #866

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

williaster
Copy link
Collaborator

🏠 Internal

Adds tests for new BarStack functionality introduced in the base branch #865.

@kristw

@coveralls
Copy link

coveralls commented Oct 13, 2020

Pull Request Test Coverage Report for Build 185

  • 3 of 5 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.6%) to 58.578%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-xychart/test/mocks/getDataContext.ts 1 3 33.33%
Totals Coverage Status
Change from base Build 156: 3.6%
Covered Lines: 1364
Relevant Lines: 2254

💛 - Coveralls

@williaster williaster force-pushed the chris--xychart-stackedbar-tests branch from 406603f to 6ec13a9 Compare October 15, 2020 23:02
@williaster williaster merged commit 9612b6f into chris--xychart-stackedbar Oct 15, 2020
@williaster williaster deleted the chris--xychart-stackedbar-tests branch October 15, 2020 23:03
@williaster williaster added this to the 1.1.0 milestone Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants