Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove dead link and add one link #867

Merged
merged 1 commit into from
Oct 13, 2020
Merged

refactor: remove dead link and add one link #867

merged 1 commit into from
Oct 13, 2020

Conversation

ArvinH
Copy link
Contributor

@ArvinH ArvinH commented Oct 13, 2020

📝 Documentation

  • Remove some dead link in the readme (some of them might just need to re-deploy 🤔 so if we shouldn't remove them, I can put them back)
  • Add one link of mine, the UI of the demo and the tutorial is written in Traditional Chinese and has been shared by the newsletter I'm running

screencast

@coveralls
Copy link

coveralls commented Oct 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.984%
Totals Coverage Status
Change from base Build 158: 0.0%
Covered Lines: 1285
Relevant Lines: 2184
💛 - Coveralls

@hshoff hshoff added this to the 1.0.1 milestone Oct 13, 2020
hshoff
hshoff approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for the contribution and great work on the demo!

@hshoff hshoff merged commit 8186de6 into airbnb:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
📝 docs
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ArvinH @coveralls @hshoff