new(xychart): add AnimatedLineSeries + tests #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
force-pushed
the
chris--xychart-animated-line
branch
from
6473ece
to
e882b46
Compare
williaster
commented
Oct 15, 2020
| {...lineProps} | ||
| > | ||
| {({ path }) => ( | ||
| <PathComponent stroke={color} strokeWidth={2} {...lineProps} d={path(data) || ''} /> |
There was a problem hiding this comment.
everything is the same in this file except we use the child render function here.
sorry I tried to git mv and it didn't work in this UI view 💔
2 tasks
williaster
commented
Oct 15, 2020
| @@ -16,6 +16,6 @@ export default function getScaledValueFactory<Scale extends AxisScale, Datum>( | |||
| (align === 'start' ? 0 : getScaleBandwidth(scale)) / (align === 'center' ? 2 : 1); | |||
| return scaledValue + bandwidthOffset; | |||
| } | |||
| return NaN; | |||
| return null; | |||
There was a problem hiding this comment.
this one is tricky. react-spring barfs on NaN, but all of the types expect number not number | null 🤔
williaster
force-pushed
the
chris--xychart-animated-bar
branch
from
b388988
to
fe7d094
Compare
williaster
force-pushed
the
chris--xychart-animated-line
branch
from
e882b46
to
4badb0d
Compare
Pull Request Test Coverage Report for Build 256
💛 - Coveralls |
kristw
approved these changes
Oct 21, 2020
hshoff
approved these changes
Oct 22, 2020
williaster
force-pushed
the
chris--xychart-animated-line
branch
from
1b12022
to
81044b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
masterwhen parent new(xychart): add Animated(BarSeries, BarStack, BarGroup) #873 is merged🚀 Enhancements
This PR adds an
AnimatedLineSeriescomponent. It factors out the previousLineSeries=>BaseLineSeriesto power bothLineSeriesand theAnimatedLineSeries.🏠 Internal
Adds tests for
Animated(LineSeries,BarSeries,BarStack,BarGroup)components@kristw @techniq