Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(xychart): add Annotations tests #948

Merged
merged 2 commits into from
Dec 2, 2020
Merged

test(xychart): add Annotations tests #948

merged 2 commits into from
Dec 2, 2020

Conversation

williaster
Copy link
Collaborator

馃彔 Internal

This PR adds tests for @visx/xychart annotations added in #938

@kristw @hshoff

@williaster williaster added this to the 1.2.1 milestone Nov 26, 2020
@williaster williaster added this to Reviewable in XYChart via automation Nov 26, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 384245720

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 61.275%
Totals Coverage Status
Change from base Build 383897138: 1.4%
Covered Lines: 1667
Relevant Lines: 2571
馃挍 - Coveralls

@williaster williaster merged commit b6a455e into master Dec 2, 2020
XYChart automation moved this from Reviewable to Done Dec 2, 2020
@williaster williaster deleted the chris--xychart-annotation-tests branch December 2, 2020 18:57
@williaster williaster modified the milestones: 1.2.1, 1.3.0 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw Awaiting requested review from kristw

Assignees
No one assigned
Labels
馃彔 internal @visx/xychart
Projects
XYChart
  
Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@williaster @coveralls @hshoff