Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tooltip] Corrects a documentation error #970

Merged
merged 1 commit into from
Dec 14, 2020
Merged

[tooltip] Corrects a documentation error #970

merged 1 commit into from
Dec 14, 2020

Conversation

jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Dec 11, 2020

💥 Breaking Changes

🚀 Enhancements

📝 Documentation

  • Corrects an error in the tooltip readme where the prop table for TooltipWithBounds lists offsetTop as offsetRight.

🐛 Bug Fix

🏠 Internal

@coveralls
Copy link

Pull Request Test Coverage Report for Build 416311397

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.258%
Totals Coverage Status
Change from base Build 413784565: 0.0%
Covered Lines: 1732
Relevant Lines: 2694
💛 - Coveralls

williaster
williaster approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the catch + fix @jfuchs 💯

@williaster williaster added this to the 1.3.0 milestone Dec 14, 2020
@williaster williaster merged commit 31087ed into airbnb:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
📝 docs @visx/tooltip
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jfuchs @coveralls @williaster