🐛 Source Mixpanel : Fix Export HTTP Response Parsing

[guillaume-chech]

Testing!!!## What
Export stream processing could fail in some edge cases where individual Export text properties would contains line breaks causing the json parser to fail. As reported here #11018

How

The solution replaces the usage of response.text.splitlines() by the use of the HTTP response response.iter_lines() method. No other changes implemented.

Recommended reading order

1. source_mixpanel/souce.py

🚨 User Impact 🚨

No impact expected. Change should be transparent.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/SUMMARY.md
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the new connector version is published, connector version bumped in the seed directory as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

Tests

Unit

Results (0.20s):
       1 passed

Integration

Test session starts (platform: darwin, Python 3.8.2, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/guillaume/Shotgun/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, timeout-1.4.2
collecting ... 

Results (0.01s):

Acceptance

I did not manage to run those likely that something is wrong with my setup.

[CLAassistant]

All committers have signed the CLA.

[marcosmarxm]

Can you sign the CLA @guillaume-chech ? Also can you share the integration tests or a screenshoot showing the modification solves the issue?

[marcosmarxm]

Overall the change looks great thanks @guillaume-chech

[guillaume-chech]

Sorry about the acceptance test not being implemented, I'm a bit short on time and my pyhton skills are a bit rusty so i'll go for the good old with or without run "proof"

Sure here is a proof of the fix working ,I ran this command to test on a faulty day of data :
python3 main.py read --config secrets/config.json --catalog integration_tests/configured_catalog_export.json

And without the fix :

[marcosmarxm]

/test connector=connectors/source-mixpanel repo=guillaume-chech/airbyte

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2030078647

[guillaume-chech]

@marcosmarxm Looks like something went wrong with the acceptance test run. Do you have more logs of the run, it's just saying that the instance was killed :)

[marcosmarxm]

Our Mixpanel CI is broke @guillaume-chech I'm working to fix it and run tests with your changes

[marcosmarxm]

Our Mixpanel CI is broke @guillaume-chech I'm working to fix it and run tests with your changes

@guillaume-chech I'm working to remove data from our integration accoun, hope tomorrow I can test your changes and merged it.

[guillaume-chech]

@marcosmarxm Did you manage to implement a fix for the CI ?