🐛 Source Amazon Ads: test coverage more than 90% + improve test speed #11384

grubberr · 2022-03-24T06:15:20Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Improve unit test coverage at least 90%
Improve test speed
Update pendulum 1.5 -> 2.1
Improve error handling
Improve acceptance test organization

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-24T06:17:41Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2032590913
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2032590913
🐛 https://gradle.com/s/tgnypbzpyfml2
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs3] - docker.errors.Contai...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 1 failed, 22 passed, 1 skipped in 31.07s ===================

codecov · 2022-03-24T06:23:29Z

Codecov Report

❗ No coverage uploaded for pull request base (master@83817cc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11384   +/-   ##
=========================================
  Coverage          ?   98.77%           
=========================================
  Files             ?       22           
  Lines             ?      652           
  Branches          ?        0           
=========================================
  Hits              ?      644           
  Misses            ?        8           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83817cc...f5adf6c. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-24T10:30:44Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2033695309
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2033695309
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          16      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/common.py                                  78      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            23      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          190      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               646      7    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 23 passed, 1 skipped in 20.57s ========================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-24T12:04:31Z

/test connector=connectors/source-amazon-ads

airbyte-integrations/connectors/source-amazon-ads/unit_tests/test_report_streams.py

grubberr · 2022-03-28T10:08:12Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2051583563
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2051583563
🐛 https://gradle.com/s/i4xidkkzulb74
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contai...
FAILED test_core.py::TestBasicRead::test_read[inputs2] - docker.errors.Contai...
FAILED test_core.py::TestBasicRead::test_read[inputs3] - Failed: Stream profi...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 4 failed, 19 passed, 1 skipped in 15.51s ===================

AmazonAdsStream improve error handling Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-28T21:00:35Z

/test connector=connectors/source-amazon-ads

grubberr · 2022-03-28T21:12:36Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2054934575
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2054934575
🐛 https://gradle.com/s/sbsz6laui3iyq

grubberr · 2022-03-28T21:30:42Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2055012539
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2055012539
🐛 https://gradle.com/s/u7rjg7ntffkm4

grubberr · 2022-03-28T21:33:58Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2055026779
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2055026779
🐛 https://gradle.com/s/y4sou26xt3i3o

grubberr · 2022-03-29T11:18:18Z

/test connector=connectors/source-amazon-ads

grubberr · 2022-03-29T11:49:24Z

/test connector=connectors/source-amazon-ads

grubberr · 2022-03-29T12:17:43Z

/test connector=connectors/source-amazon-ads

grubberr · 2022-03-29T13:30:55Z

/test connector=connectors/source-amazon-ads

grubberr · 2022-03-29T14:11:45Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2059050948
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2059050948
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          16      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            23      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          191      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               646      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 23 passed, 1 skipped in 23.20s ========================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-03-30T19:45:54Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2067049219
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2067049219
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          16      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            23      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          191      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               646      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 23 passed, 1 skipped in 22.84s ========================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-05T06:32:12Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2094415338
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2094415338
🐛 https://gradle.com/s/xqk3gslvd2wue
Python short test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestBasicRead::test_read[inputs1] - FileNotFoundError: [E...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 21 passed, 1 skipped, 2 errors in 201.08s (0:03:21) ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-05T06:47:56Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2094476501
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2094476501
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          16      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            25      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               657      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 207.26s (0:03:27) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-05T08:37:00Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2094970463
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2094970463
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          17      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            25      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               658      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 330.83s (0:05:30) ===================

midavadim · 2022-04-08T11:46:51Z

This update can be released without Airbyte review.

midavadim

Approved

grubberr · 2022-04-08T13:43:29Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2115519058
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2115519058
🐛 https://gradle.com/s/violv2nfl7rc2
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >300.0s
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 22 passed, 1 skipped in 1494.32s (0:24:54) =============

grubberr · 2022-04-08T14:41:30Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2115827637
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2115827637
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          17      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            25      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               658      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 636.15s (0:10:36) ===================

pendulum~=1.5.1 -> pendulum~=2.1.2

f46e1e3

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this Mar 24, 2022

grubberr linked an issue Mar 24, 2022 that may be closed by this pull request

🐛 Source Amazon Ads: test coverage more than 90% + improve test speed #11367

Closed

github-actions bot added the area/connectors Connector related issues label Mar 24, 2022

grubberr added 2 commits March 24, 2022 08:48

sleep_mock added

dc05685

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

mock sleep, pendulum fix

e9ade40

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/11367-source-amazon-ads

227e6ad

grubberr changed the title ~~🐛 Source Amazon Ads: test coverage more than 90%~~ 🐛 Source Amazon Ads: test coverage more than 90% + improve test speed Mar 24, 2022

grubberr requested review from bazarnov and davydov-d March 24, 2022 11:17

bugfix datetime -> DateTime

e06f1c9

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

davydov-d approved these changes Mar 24, 2022

View reviewed changes

airbyte-integrations/connectors/source-amazon-ads/unit_tests/test_report_streams.py Show resolved Hide resolved

bazarnov approved these changes Mar 25, 2022

View reviewed changes

Merge branch 'master' into grubberr/11367-source-amazon-ads

ca260ad

grubberr added 2 commits March 28, 2022 19:31

Merge branch 'master' into grubberr/11367-source-amazon-ads

5725ee6

add more expected records

0c95c82

AmazonAdsStream improve error handling Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/11367-source-amazon-ads

8579963

grubberr added 2 commits March 29, 2022 08:15

Merge branch 'master' into grubberr/11367-source-amazon-ads

4f87bff

Merge branch 'master' into grubberr/11367-source-amazon-ads

40b0bc4

grubberr requested a review from ChristopheDuong March 29, 2022 14:27

Merge branch 'master' into grubberr/11367-source-amazon-ads

77d4582

grubberr requested a review from midavadim March 30, 2022 11:19

grubberr added 2 commits March 30, 2022 17:35

Merge branch 'master' into grubberr/11367-source-amazon-ads

a32b43e

stream 'sponsored_product_ads' has some data now

237f944

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 2 commits April 5, 2022 09:23

Merge branch 'master' into grubberr/11367-source-amazon-ads

b17cb18

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

re-organize acceptance-test-config

fdf1880

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fixed

649393f

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

SponsoredProductsReportStream.primary_key added

2b43f9c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested review from sherifnada and removed request for ChristopheDuong April 5, 2022 14:50

midavadim approved these changes Apr 8, 2022

View reviewed changes

Merge branch 'master' into grubberr/11367-source-amazon-ads

f5adf6c

grubberr merged commit ceef3e3 into master Apr 8, 2022

grubberr deleted the grubberr/11367-source-amazon-ads branch April 8, 2022 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Amazon Ads: test coverage more than 90% + improve test speed #11384

🐛 Source Amazon Ads: test coverage more than 90% + improve test speed #11384

grubberr commented Mar 24, 2022 •

edited

Loading

grubberr commented Mar 24, 2022 •

edited by github-actions bot

Loading

codecov bot commented Mar 24, 2022 •

edited

Loading

grubberr commented Mar 24, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 24, 2022

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

midavadim commented Apr 8, 2022

midavadim left a comment

grubberr commented Apr 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 8, 2022 •

edited by github-actions bot

Loading

🐛 Source Amazon Ads: test coverage more than 90% + improve test speed #11384

🐛 Source Amazon Ads: test coverage more than 90% + improve test speed #11384

Conversation

grubberr commented Mar 24, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Mar 24, 2022 • edited by github-actions bot Loading

codecov bot commented Mar 24, 2022 • edited Loading

Codecov Report

grubberr commented Mar 24, 2022 • edited by github-actions bot Loading

grubberr commented Mar 24, 2022

grubberr commented Mar 28, 2022 • edited by github-actions bot Loading

grubberr commented Mar 28, 2022

grubberr commented Mar 28, 2022 • edited by github-actions bot Loading

grubberr commented Mar 28, 2022 • edited by github-actions bot Loading

grubberr commented Mar 28, 2022 • edited by github-actions bot Loading

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022

grubberr commented Mar 29, 2022 • edited by github-actions bot Loading

grubberr commented Mar 30, 2022 • edited by github-actions bot Loading

grubberr commented Apr 5, 2022 • edited by github-actions bot Loading

grubberr commented Apr 5, 2022 • edited by github-actions bot Loading

grubberr commented Apr 5, 2022 • edited by github-actions bot Loading

midavadim commented Apr 8, 2022

midavadim left a comment

Choose a reason for hiding this comment

grubberr commented Apr 8, 2022 • edited by github-actions bot Loading

grubberr commented Apr 8, 2022 • edited by github-actions bot Loading

grubberr commented Mar 24, 2022 •

edited

Loading

grubberr commented Mar 24, 2022 •

edited by github-actions bot

Loading

codecov bot commented Mar 24, 2022 •

edited

Loading

grubberr commented Mar 24, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 29, 2022 •

edited by github-actions bot

Loading

grubberr commented Mar 30, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 8, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 8, 2022 •

edited by github-actions bot

Loading