Improve performance of connectionOperation functions #11702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
lmossman
approved these changes
Apr 6, 2022
| } | ||
|
|
||
| @Test | ||
| public void testDeleteStandardSync() |
There was a problem hiding this comment.
Suggested change
| public void testDeleteStandardSync() | |
| public void testDeleteStandardSyncOperation() |
| @@ -173,9 +173,9 @@ public void deleteOperationsForConnection(final StandardSync standardSync, final | |||
| for (final UUID operationId : deleteOperationIds) { | |||
| operationIds.remove(operationId); | |||
| boolean sharedOperation = false; | |||
| for (final StandardSync sync : allStandardSyncs) { | |||
| for (final StandardSync sync : configRepository.listStandardSyncsUsingOperation(operationId)) { | |||
There was a problem hiding this comment.
I'm not able to comment on it, but line 171 should be removed from this function, since we no longer need to list all standard syncs:
final List<StandardSync> allStandardSyncs = configRepository.listStandardSyncs();
If this is not removed, we likely will not see as much of a performance improvement from this as we would like!
There was a problem hiding this comment.
Thanks, I removed the line.
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Optimize the way we fetch and delete connections operations
How
Create function in
ConfigRepositoryusing direct SQL toRecommended reading order