-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Destination: Implement Destination Google Sheets
using CDK
#12135
Conversation
…ov/11918-destination-google-sheets
…ination-google-sheets
…ination-google-sheets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
No major blocking comments, but mainly around correctness & thus readability.
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/buffer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/buffer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/buffer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/buffer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/buffer.py
Show resolved
Hide resolved
...e-integrations/connectors/destination-google-sheets/destination_google_sheets/spreadsheet.py
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/writer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/destination_google_sheets/writer.py
Show resolved
Hide resolved
...e-integrations/connectors/destination-google-sheets/destination_google_sheets/destination.py
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-google-sheets/setup.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting change after reading the scoping doc:
- We need to gracefully handle the case where there are more than 200 streams as described in this comment thread. We should also integration test this behaviour.
airbyte-integrations/connectors/destination-google-sheets/integration_tests/integration_test.py
Show resolved
Hide resolved
As for this part, I'm completely aware this is the biggest limitation at this moment. We need to understand how customers will use the connector first (a lot of data vs small data amounts, one time syncs vs continuous sync process) before we try to workaround this. There are couple of ways how this could be handled correctly, however we need to understand how to deliver the it's should be agreed with the @sherifnada we go this way, correct me if I'm wrong here.
The documentation describes these limitations, so the customer should be informed. |
/test connector=connectors/destination-google-sheets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making the changes 🚀
/publish connector=connectors/destination-google-sheets
|
What
Resolving: #11918
How
Destination Google Sheets
usingAirbyte Python CDK
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:destination-google-sheets:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/destination/google-sheets.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here