-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉🐛: Source mongoDB: implement building JsonSchema with 'properties' for fields with type 'object' #12428
Conversation
2291e8c
to
5e18168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
|
||
/** | ||
* If one field has different types in 2 and more documents, the name is transofmed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: transformed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, did you run tests in CI? I dont see them having run from "Sonar Scan / Tests for ${{ matrix.module }} (pull_request)". Also are you going to bump version in this PR or do you usually do a follow up?
/test connector=connectors/source-mongodb-v2
|
2d821c6
to
f73543d
Compare
@noahkawasaki-airbyte thanks for the review. |
/publish connector=connectors/source-mongodb-v2
|
…or fields with type 'object' (#12428) * mongodb: build JsonSchema with 'properties' * add tests * bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Fixed #8586
On the source-mongodb-v2 implemented building JsonSchema with nested properties for fields with type "object"
How
Add recursive fetching of fields and types from mongo collection. Modified
CommonField
andField
classes to support subfields.Recommended reading order
MongoUtils.java
MongoDBSource.java
CatalogHelpers.java
🚨 User Impact 🚨
Users will be able to see on the UI all fields and types including all sublevels fields.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.