Source MSSQL: add option to disable Snapshot mode and initial backup #12759

sivankumar86 · 2022-05-11T04:21:57Z

What

Describe what the change is solving
Added option to disable initial snapshot and enabling snapshot mode as we use read_committed replica which is not required to enable snapshot isolation

#12592

How

There is a option in debezium connector to disable snapshot isolation mode.

 // below option would not lock the table 
  
props.setProperty("snapshot.isolation.mode", "read_committed");

//below. option would not take initial snapshot and only capture changes 

props.setProperty("snapshot.mode", "schema_only");

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-05-11T04:25:48Z

All committers have signed the CLA.

sivankumar86 · 2022-05-11T04:32:55Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sivakumar Ramaswamy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

i did digital sign but, it is not working

snapshot isolation setting is hardcode and I modified as user option

docker version change

alafanechere · 2022-05-16T21:11:07Z

@sivankumar86 thank you for this contribution! To fix the CLA signature I think you need to make sure that your git config email is the same as your using for GitHub. You committed with your Gmail address, is it the same email as your github account email?

alafanechere · 2022-05-16T21:12:26Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2334701729
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2334701729
🐛 https://gradle.com/s/fw7xbuz6nv3xk

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2334701729
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2334701729
No Python unittests run

sivankumar86 · 2022-05-16T23:09:27Z

@sivankumar86 thank you for this contribution! To fix the CLA signature I think you need to make sure that your git config email is the same as your using for GitHub. You committed with your Gmail address, is it the same email as your github account email?

Thanks for reply. I added email address which was being used to commit and it got resolved.

alafanechere · 2022-05-18T14:40:58Z

I'd love a review from the connector team on this. @sivankumar86 I'm wondering to what extent this change can be propagated to other CDC compatible source databases. Is anything specific to MSSQL in your modifications?

tuliren

@sivankumar86, thank you for the contribution!

The overall design looks good. However, since multiple configurations have been introduced to the CDC method, the replication_method needs to be changed to an object. In addition, I think some unit tests and a new test case in the acceptance test are necessary.

I will create a PR based on your PR, and make all the changes mentioned in the review. When all those are done, I will merge your PR and then my patch.

...tors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlCdcProperties.java

airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java

subodh1810 · 2022-05-18T17:56:26Z

Should this change be across Postgres and Mysql connectors as well for consistency?

tuliren · 2022-05-18T18:10:49Z

Should this change be across Postgres and Mysql connectors as well for consistency?

Yes.

airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java

grishick · 2022-05-18T23:26:44Z

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java

+    if(cdcMethod.hasNonNull("is_snapshotDisabled") &&
+            cdcMethod.get("is_snapshotDisabled").asBoolean()) {
+      props.setProperty("snapshot.isolation.mode", "read_committed");
+    }


nit: preferred formatting:
'} else {'

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java

docs/integrations/sources/mssql.md

tuliren · 2022-05-19T17:11:01Z

Should this change be across Postgres and Mysql connectors as well for consistency?

I looked into this more closely. Different databases actually have different CDC settings. Since this is not a planned sprint project, I will not apply this change to Postgres or MySQL this time. Will create a ticket to track it in the future.

removed extra space

sivankumar86 · 2022-05-22T03:56:01Z

@tuliren Thank you for providing review/feedback. I have changed the code and it is specific to mssql server hence, it may not suitable for other connector. could you take a look on new changes ?

alafanechere · 2022-05-23T07:27:34Z

I handover the assignment to @grishick as the DB connector team is currently working on this.

tuliren · 2022-05-23T21:47:07Z

@alafanechere, @grishick, I am already working on this. Please let me push this to the finishing line. Switching the assignee at this moment will slow it down.

@sivankumar86, thank you very much. You can leave the PR as is. I am working on a PR on top of this to add a few more optimizations. Once this is one, I will merge this PR.

sivankumar86 · 2022-05-23T23:10:43Z

@alafanechere, @grishick, I am already working on this. Please let me push this to the finishing line. Switching the assignee at this moment will slow it down.

@sivankumar86, thank you very much. You can leave the PR as is. I am working on a PR on top of this to add a few more optimizations. Once this is one, I will merge this PR.

@tuliren thank you for taking ownership. Could you please provide me your PR link so that I can subscribe and also, it would be great if you can push to main asap .

tuliren · 2022-05-25T12:39:30Z

@sivankumar86, the PR is here: #13168

tuliren · 2022-05-26T03:14:31Z

I ran into some issue when trying to publish a new version for the MSSQL connector. Still working on it in #13176.

…pshot isolation level (airbytehq#12759) * MSSQL CDC feature to capture only changes option added * MSSQL CDC feature to capture only changes option added * added option to disable snapshot snapshot isolation setting is hardcode and I modified as user option * recommitting * docker version change docker version change * resolve conflict * review 1 added * review 1 added * removed extra space removed extra space

sivankumar86 added 2 commits May 11, 2022 14:15

MSSQL CDC feature to capture only changes option added

0828f8e

MSSQL CDC feature to capture only changes option added

874fff2

github-actions bot added the area/connectors Connector related issues label May 11, 2022

octavia-squidington-iii added the community label May 11, 2022

sivankumar86 mentioned this pull request May 11, 2022

MSSQL CDC feature to capture only changes from now #12592

Closed

added option to disable snapshot

86ae3f1

snapshot isolation setting is hardcode and I modified as user option

github-actions bot added the area/documentation Improvements or additions to documentation label May 11, 2022

sivankumar86 and others added 5 commits May 13, 2022 09:30

recommitting

03d04c1

docker version change

6237ab8

docker version change

resolve conflict

c0393a5

Merge branch 'master' of https://github.com/sivankumar86/airbyte

aadd7f1

resolve conflict

5d23be3

alafanechere changed the title ~~added option to disable Snapshot mode and initial backup in mssql connector~~ Source MSSQL: add option to disable Snapshot mode and initial backup May 16, 2022

alafanechere self-assigned this May 16, 2022

tuliren suggested changes May 18, 2022

View reviewed changes

grishick reviewed May 18, 2022

View reviewed changes

airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json Outdated Show resolved Hide resolved

grishick reviewed May 18, 2022

View reviewed changes

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java Outdated Show resolved Hide resolved

grishick reviewed May 18, 2022

View reviewed changes

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java Outdated Show resolved Hide resolved

grishick reviewed May 18, 2022

View reviewed changes

docs/integrations/sources/mssql.md Outdated Show resolved Hide resolved

review 1 added

50c7a1a

sivankumar86 and others added 2 commits May 22, 2022 13:51

review 1 added

8e56a91

removed extra space

6818b1e

removed extra space

sivankumar86 requested a review from tuliren May 22, 2022 03:54

alafanechere assigned grishick and unassigned alafanechere May 23, 2022

tuliren assigned tuliren and unassigned grishick May 23, 2022

tuliren mentioned this pull request May 25, 2022

Patch for mssql source cdc update #13168

Merged

tuliren merged commit 90b757b into airbytehq:master May 25, 2022

tuliren mentioned this pull request May 25, 2022

Publish new mssql source #13176

Merged

octavia-squidington-iii mentioned this pull request May 25, 2022

Bump Airbyte version from 0.39.1-alpha to 0.39.2-alpha #13188

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source MSSQL: add option to disable Snapshot mode and initial backup #12759

Source MSSQL: add option to disable Snapshot mode and initial backup #12759

sivankumar86 commented May 11, 2022 •

edited

Loading

CLAassistant commented May 11, 2022 •

edited

Loading

sivankumar86 commented May 11, 2022

alafanechere commented May 16, 2022

alafanechere commented May 16, 2022 •

edited by github-actions bot

Loading

sivankumar86 commented May 16, 2022 •

edited

Loading

alafanechere commented May 18, 2022

tuliren left a comment

subodh1810 commented May 18, 2022

tuliren commented May 18, 2022

grishick May 18, 2022

tuliren commented May 19, 2022

sivankumar86 commented May 22, 2022

alafanechere commented May 23, 2022

tuliren commented May 23, 2022

sivankumar86 commented May 23, 2022

tuliren commented May 25, 2022

tuliren commented May 26, 2022

Source MSSQL: add option to disable Snapshot mode and initial backup #12759

Source MSSQL: add option to disable Snapshot mode and initial backup #12759

Conversation

sivankumar86 commented May 11, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented May 11, 2022 • edited Loading

sivankumar86 commented May 11, 2022

alafanechere commented May 16, 2022

alafanechere commented May 16, 2022 • edited by github-actions bot Loading

sivankumar86 commented May 16, 2022 • edited Loading

alafanechere commented May 18, 2022

tuliren left a comment

Choose a reason for hiding this comment

subodh1810 commented May 18, 2022

tuliren commented May 18, 2022

grishick May 18, 2022

Choose a reason for hiding this comment

tuliren commented May 19, 2022

sivankumar86 commented May 22, 2022

alafanechere commented May 23, 2022

tuliren commented May 23, 2022

sivankumar86 commented May 23, 2022

tuliren commented May 25, 2022

tuliren commented May 26, 2022

sivankumar86 commented May 11, 2022 •

edited

Loading

CLAassistant commented May 11, 2022 •

edited

Loading

alafanechere commented May 16, 2022 •

edited by github-actions bot

Loading

sivankumar86 commented May 16, 2022 •

edited

Loading