Repository navigation
Migrate Postgres and MySql to use new JdbcSource - #1307
Merged
Merged
Conversation
Charles (cgardens)
changed the base branch from
master
to
cgardens/jdbc_source_incremental4
December 13, 2020 21:06
Charles (cgardens)
force-pushed
the
cgardens/jdbc_source_incremental4
branch
4 times, most recently
from
December 18, 2020 22:09
0d400d7 to
7d48ef4
Compare
Charles (cgardens)
force-pushed
the
cgardens/jdbc_source_incremental5
branch
from
December 23, 2020 01:46
19e6f62 to
2325e8f
Compare
Charles (cgardens)
marked this pull request as ready for review
December 23, 2020 01:54
Charles (cgardens)
requested review from
Jared Rhizor (jrhizor),
Michel Tricot (michel-tricot) and
Sherif A. Nada (sherifnada)
December 23, 2020 01:54
Charles (cgardens)
changed the title
Michel Tricot (michel-tricot)
approved these changes
Dec 23, 2020
Michel Tricot (michel-tricot)
left a comment
Michel Tricot (michel-tricot)
left a comment
Contributor
There was a problem hiding this comment.
Tada!
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.testcontainers.containers.MySQLContainer; | ||
|
|
||
| class MySqlDbSourceStandardTest extends JdbcSourceStandardTest { |
Contributor
There was a problem hiding this comment.
NIT: remove the db from the name
| import org.testcontainers.containers.PostgreSQLContainer; | ||
| import org.testcontainers.utility.MountableFile; | ||
|
|
||
| class PostgresDbSourceStandardTest extends JdbcSourceStandardTest { |
Contributor
There was a problem hiding this comment.
Same NIT
| * in source-postgres. | ||
| */ | ||
| @Disabled | ||
| class PostgresJdbcJdbcStressTest extends JdbcStressTest { |
Contributor
There was a problem hiding this comment.
You can can remove one of the JDBC :)
Charles (cgardens)
force-pushed
the
cgardens/jdbc_source_incremental5
branch
from
January 4, 2021 15:38
8c487d9 to
3d490fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What