🐛 Source Amazon Ads: SANDBOX removed #14871

grubberr · 2022-07-20T08:41:47Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Remove any reference to "SANDBOX" environment because of this:
https://advertising.amazon.com/API/docs/en-us/info/release-notes#sandbox-deprecation-on-june-28-2022

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-07-20T08:43:26Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2703418200
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2703418200
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        6      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               632      8    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 1 skipped in 2703.37s (0:45:03) ==================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-07-20T16:49:49Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2706312186
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2706312186
🐛 https://gradle.com/s/ko2atdf3fnpka

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 21 passed, 1 skipped in 3126.56s (0:52:06) =============

grubberr · 2022-07-20T21:11:19Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2707703373
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2707703373
🐛 https://gradle.com/s/3n3du6u62vcuu

Build Failed

Test summary info:

Could not find result summary

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2707703373
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2707703373
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        6      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  76      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               632      8    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 1 skipped in 1933.47s (0:32:13) ==================

grubberr · 2022-07-28T12:02:40Z

closed because all will be implemented here #15031

SANDBOX removed

c0753e0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr linked an issue Jul 20, 2022 that may be closed by this pull request

Source Amazon Ads: remove "SANDBOX" account #14870

Closed

github-actions bot added the area/connectors Connector related issues label Jul 20, 2022

octavia-squidington-iii added the connectors/source/amazon-ads label Jul 20, 2022

grubberr self-assigned this Jul 20, 2022

bump version to 0.1.10

b051455

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Jul 20, 2022

update SAT tests

2afab8f

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/14870-source-amazon-ads

8e86cfd

grubberr closed this Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Amazon Ads: SANDBOX removed #14871

🐛 Source Amazon Ads: SANDBOX removed #14871

grubberr commented Jul 20, 2022 •

edited

Loading

grubberr commented Jul 20, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 20, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 20, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 28, 2022

🐛 Source Amazon Ads: SANDBOX removed #14871

🐛 Source Amazon Ads: SANDBOX removed #14871

Conversation

grubberr commented Jul 20, 2022 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Jul 20, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Jul 20, 2022 • edited by github-actions bot Loading

Build Failed

grubberr commented Jul 20, 2022 • edited by github-actions bot Loading

Build Failed

Build Passed

grubberr commented Jul 28, 2022

grubberr commented Jul 20, 2022 •

edited

Loading

grubberr commented Jul 20, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 20, 2022 •

edited by github-actions bot

Loading

grubberr commented Jul 20, 2022 •

edited by github-actions bot

Loading