Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Google Analytics v4: Add handle quota error #14949

Merged

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Jul 21, 2022

What

https://github.com/airbytehq/oncall/issues/346 - When daily limits error reached, sync failed.

How

Added handle quota error. When the daily request limit reached, the connector ignores an error with 429 code and has exceeded the daily request limit error massage to finish successfully sync and inform the user about an error in logs with an error message and link to google analytics docs.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 21, 2022
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jul 22, 2022

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2718218317
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2718218317
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_google_analytics_v4/__init__.py       2      0   100%
source_google_analytics_v4/source.py       284     26    91%
------------------------------------------------------------
TOTAL                                      286     26    91%

Build Passed

Test summary info:

All Passed

@lazebnyi lazebnyi marked this pull request as ready for review July 22, 2022 11:45
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jul 22, 2022

/publish connector=connectors/source-google-analytics-v4

🕑 Publishing the following connectors:
connectors/source-google-analytics-v4
https://github.com/airbytehq/airbyte/actions/runs/2718456950


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-v4

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi changed the title Source Google Analytics v4: Add handle quota error 🎉Source Google Analytics v4: Add handle quota error Jul 22, 2022
@lazebnyi lazebnyi merged commit e8cd4da into master Jul 22, 2022
@lazebnyi lazebnyi deleted the lazebnyi/346-google-analytics-v4-add-handle-quota-error branch July 22, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants