Jamakase/add cypress #2199
Merged
Jamakase/add cypress #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
reviewed
Feb 24, 2021
| cy.get("div").contains("Test destination cypress").should("exist"); | ||
| }); | ||
|
|
||
| it("Update connection", () => { |
There was a problem hiding this comment.
each test depends on the state created by the previous test? am i reading that right? is there a reasonable way to not have this be the case. we generally try to make it so that the state of each test is totally isolated from one another.
cgardens
approved these changes
Feb 27, 2021
jamakase
force-pushed
the
jamakase/add-cypress
branch
from
035c53f
to
8c02b9b
Compare
jamakase
force-pushed
the
jamakase/add-cypress
branch
from
80293c5
to
40cd664
Compare
jamakase
force-pushed
the
jamakase/add-cypress
branch
from
c06417d
to
41dcea3
Compare
jamakase
force-pushed
the
jamakase/add-cypress
branch
from
4781860
to
209ef99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add e2e frontend tests. Closes #1598