stop reset job endpoint from blocking #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Mar 1, 2021
| @@ -26,6 +26,7 @@ | |||
|
|
|||
| import pendulum as pendulum | |||
| from base_python import BaseClient | |||
|
|
|||
There was a problem hiding this comment.
??? i ran format. promise.
cgardens
commented
Mar 1, 2021
| @@ -195,8 +201,9 @@ public ConnectionRead webBackendUpdateConnection(WebBackendConnectionUpdate webB | |||
|
|
|||
| // wait for this to execute | |||
| JobInfoRead resetJob = schedulerHandler.resetConnection(connectionId); | |||
| final JobInfoRead completedResetJob = waitForJobToComplete(resetJob.getJob().getId()); | |||
There was a problem hiding this comment.
this endpoint (updating a connection, still needs to block and until the reset job is complete, so we have to add that logic here)
There was a problem hiding this comment.
i guess we could just not. if the reset fails then the destination will have a combination of data from different schemas.
jrhizor
approved these changes
Mar 1, 2021
michel-tricot
approved these changes
Mar 1, 2021
|
|
||
| public class WebBackendConnectionsHandler { | ||
|
|
||
| private static final Set<JobStatus> TERMINAL_STATUSES = Sets.newHashSet(JobStatus.FAILED, JobStatus.SUCCEEDED, JobStatus.CANCELLED); |
There was a problem hiding this comment.
I can see this set becoming handy outside of the webbackend. Is there a more approriate place where it could belong?
| @@ -195,8 +201,9 @@ public ConnectionRead webBackendUpdateConnection(WebBackendConnectionUpdate webB | |||
|
|
|||
| // wait for this to execute | |||
| JobInfoRead resetJob = schedulerHandler.resetConnection(connectionId); | |||
| final JobInfoRead completedResetJob = waitForJobToComplete(resetJob.getJob().getId()); | |||
cgardens
force-pushed
the
cgardens/reset_wait
branch
from
e4c792c
to
83f4b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What