Source S3: infer schema of the first file only - #23189
Merged
Denys Davydov (davydov-d) merged 13 commits intoMar 14, 2023
Merged
Source S3: infer schema of the first file only#23189Denys Davydov (davydov-d) merged 13 commits into
Denys Davydov (davydov-d) merged 13 commits into
Conversation
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Author
|
/test connector=connectors/source-s3
Build FailedTest summary info: |
Contributor
Author
|
☝️ the failing test is not related to this PR |
Contributor
Author
this PR fixes the error above |
Baz (bazarnov)
approved these changes
Feb 17, 2023
Baz (bazarnov)
left a comment
Baz (bazarnov)
left a comment
Contributor
There was a problem hiding this comment.
LGMT for the precise fix you did, but failing tests are not going to allow you to merge it the way it should be, right, maybe the order of operations should be different here and you might want to merge the avro fix first.
Augustin (alafanechere)
suggested changes
Feb 20, 2023
Augustin (alafanechere)
left a comment
Augustin (alafanechere)
left a comment
Contributor
There was a problem hiding this comment.
Thank for the effort. The overall logic looks good to me but I have a couple of questions/suggestions.
Contributor
Author
|
Hey Augustin (@alafanechere) can you please take a look at the comments I've left? |
…es' of github.com:airbytehq/airbyte into ddavydov/#1470-source-s3-do-not-infer-schema-of-all-files
Contributor
Author
|
/test connector=connectors/source-s3
Build FailedTest summary info: |
Contributor
Author
|
/test connector=connectors/source-s3
Build PassedTest summary info: |
Augustin (alafanechere)
approved these changes
Feb 24, 2023
Augustin (alafanechere)
left a comment
Augustin (alafanechere)
left a comment
Contributor
There was a problem hiding this comment.
Thank for the changes! I just have minor suggestions remaining.
Please sync with @airbytehq/cloud-support and Yowan Ramchoreeter (@YowanR) to decide if it's safe to deploy this potentially backward version to all customers now.
If not I would suggest pinning the version to 1.0.0 on Cloud and wait for our "feature flag" functionality to test this version on a subset of users.
Contributor
Author
|
Augustin (@alafanechere) thanks! What is the "feature flag" functionality? Do you have any links? |
Contributor
|
Denys Davydov (@davydov-d) It's a project Pedro S. Lopez (@pedroslopez) and Ella Rohm-Ensing (@erohmensing) will tackle pretty soon. It will allow us to deploy a preview version of a connector to a subset of workspaces. Here's the tech spec if you're curious. |
Serhii Lazebnyi (lazebnyi)
approved these changes
Mar 1, 2023
Contributor
Author
|
/test connector=connectors/source-s3
Build PassedTest summary info: |
Contributor
Author
|
/publish connector=connectors/source-s3
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Denys Davydov (davydov-d)
deleted the
ddavydov/#1470-source-s3-do-not-infer-schema-of-all-files
branch
March 14, 2023 18:09
Adrienne Vermorel (adriennevermorel)
pushed a commit
to adriennevermorel/airbyte
that referenced
this pull request
Mar 17, 2023
* airbytehq#1470 Source S3: infer schema of the first file * airbytehq#1470 source s3: upd changelog * airbytehq#1470 source s3: review fixes * airbytehq#1470 source s3: review fixes * airbytehq#1470 source s3: bump version * airbytehq#1470 source s3: review fixes * auto-bump connector version --------- Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Ella Rohm-Ensing (erohmensing)
pushed a commit
that referenced
this pull request
Mar 22, 2023
* #1470 Source S3: infer schema of the first file * #1470 source s3: upd changelog * #1470 source s3: review fixes * #1470 source s3: review fixes * #1470 source s3: bump version * #1470 source s3: review fixes * auto-bump connector version --------- Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Ella Rohm-Ensing (erohmensing)
pushed a commit
that referenced
this pull request
Mar 22, 2023
* #1470 Source S3: infer schema of the first file * #1470 source s3: upd changelog * #1470 source s3: review fixes * #1470 source s3: review fixes * #1470 source s3: bump version * #1470 source s3: review fixes * auto-bump connector version --------- Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/oncall/issues/1470
How
If user enforced schema is not provided - infer file schema based on the first file only, do not iterate over all the available files