Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jamakase/update connector version #2462

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Conversation

jamakase
Copy link
Contributor

What

Closes #2218

image

@jamakase jamakase requested a review from cgardens March 15, 2021 17:35
@jamakase jamakase self-assigned this Mar 15, 2021
@auto-assign auto-assign bot requested review from davinchia and jrhizor March 15, 2021 17:35
`${this.url(params)}/list`,
params
);
const latestDefinition = await this.fetch(
Copy link
Contributor

@cgardens cgardens Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean every time you call /list you will also call /list_latest? this is okay, but if you are doing this, we might implement more aggressive caching for list_latest on the backend because it's pulling data from an external webserver. how often do we get this list? is it just once when the page loads or is it more frequent?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up @davinchia

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We call it every time on initial webapp opening as there is no other way to detect if there are some outdated containers or not from UI. Ideally, this data could be received on backend and UI can just get this as sort of notifications list or flag in settings or preferences call.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. okay if it's just when initially opening it then, we probably don't need caching now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the heads up!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make sure I understand, what does 'initial webapp opening' mean? everytime the page is refreshed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If saying page is refreshed you mean refresh button in a browser - then yes.

@jamakase jamakase merged commit 9b5f0b7 into master Mar 16, 2021
@jamakase jamakase deleted the jamakase/update-connector-version branch March 16, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Connector Versions
3 participants