Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection failed status #2546

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

jamakase
Copy link
Contributor

What

Add failed status for jobs.

Closes #2426

@jamakase jamakase self-assigned this Mar 22, 2021
@jamakase jamakase added area/frontend type/enhancement New feature or request labels Mar 22, 2021
@jamakase
Copy link
Contributor Author

@cgardens 1 more note:

What should we display if the status is null?

I made the next mapping:
inactive - gray
null - nothing
fail - red
others - green

@jamakase
Copy link
Contributor Author

During the call with @cgardens decided to add yellow or a badge of some other colour, to notify that sync was not run yet.

@jamakase
Copy link
Contributor Author

jamakase commented Mar 23, 2021

@cgardens added a yellow icon. Status sign when latestSyncJobStatus is null (sync was not run)

Снимок экрана 2021-03-24 в 01 38 51

Снимок экрана 2021-03-24 в 01 38 39

@jamakase jamakase merged commit bf882ee into master Mar 24, 2021
@jamakase jamakase deleted the jamakase/add-connection-failed-status branch March 24, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display failed connection status in UI.
2 participants