-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Mailchimp: handle unknown error in EmailActivity #25717
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-mailchimp
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but make sure we have the unit test for this case.
…05' into artem1205/source-mailchimp-OC-1905
/test connector=connectors/source-mailchimp
Build PassedTest summary info:
|
/publish connector=connectors/source-mailchimp
if you have connectors that successfully published but failed definition generation, follow step 4 here |
) * Source Mailchimp: handle unknown error in EmailActivity * Source Mailchimp: update docs * Source Mailchimp: refactor * auto-bump connector version --------- Co-authored-by: Baz <oleksandr.bazarnov@globallogic.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Resolving https://github.com/airbytehq/oncall/issues/1905
How
Handle unknown error
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.