Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Mailchimp: handle unknown error in EmailActivity #25717

Merged
merged 6 commits into from
May 3, 2023

Conversation

artem1205
Copy link
Collaborator

What

Resolving https://github.com/airbytehq/oncall/issues/1905

How

Handle unknown error

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205
Copy link
Collaborator Author

artem1205 commented May 1, 2023

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4852584580
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4852584580
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        46      1    98%
source_mailchimp/streams.py      137     13    91%
--------------------------------------------------
TOTAL                            185     14    92%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [3] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 61 passed, 4 skipped in 74.23s (0:01:14) ===================

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 1, 2023
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but make sure we have the unit test for this case.

@artem1205
Copy link
Collaborator Author

artem1205 commented May 1, 2023

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4854982622
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4854982622
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        46      1    98%
source_mailchimp/streams.py      143     10    93%
--------------------------------------------------
TOTAL                            191     11    94%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [3] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 61 passed, 4 skipped in 67.65s (0:01:07) ===================

@artem1205
Copy link
Collaborator Author

artem1205 commented May 3, 2023

/publish connector=connectors/source-mailchimp

🕑 Publishing the following connectors:
connectors/source-mailchimp
https://github.com/airbytehq/airbyte/actions/runs/4871052836


Connector Version Did it publish? Were definitions generated?
connectors/source-mailchimp 0.4.1

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205 artem1205 merged commit b5bc652 into master May 3, 2023
@artem1205 artem1205 deleted the artem1205/source-mailchimp-OC-1905 branch May 3, 2023 12:18
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
)

* Source Mailchimp: handle unknown error in EmailActivity

* Source Mailchimp: update docs

* Source Mailchimp: refactor

* auto-bump connector version

---------

Co-authored-by: Baz <oleksandr.bazarnov@globallogic.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants