Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☝ Add an optional jdbc_url_params to MySQL source connector to customize the jdbc_url string #2611

Merged
merged 15 commits into from
Mar 26, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Mar 25, 2021

What

Closes #2601 by allowing user to specify zerodatetimebehavior=Converttonull or some other options

Closes #1879

How

Add an optional connection parameter string field jdbc_url_params in the properties list of source-MySql spec

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. airbyte-integrations/connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
  2. component.ts
  3. the rest

},
"jdbc_url_params": {
"description": "Additional Parameters to pass to the jdbc url string when connecting to the database",
"type": "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like there is a very specific format expected here. can you add an example that shows adding multiple params?

@ChristopheDuong ChristopheDuong changed the base branch from master to chris/dedup-destination March 26, 2021 15:24
Base automatically changed from chris/dedup-destination to master March 26, 2021 19:23
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 26, 2021

/publish connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/691136673
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/691136673

@ChristopheDuong ChristopheDuong merged commit af43c0b into master Mar 26, 2021
@ChristopheDuong ChristopheDuong deleted the chris/jdbc-url-params branch March 26, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants