-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL option for Postgres source/destination #2757
Add SSL option for Postgres source/destination #2757
Conversation
...es/src/test/java/io/airbyte/integrations/source/postgres/PostgresJdbcStandardSourceTest.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
...es/src/test/java/io/airbyte/integrations/source/postgres/PostgresJdbcStandardSourceTest.java
Outdated
Show resolved
Hide resolved
...rs/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
For running, Postgres enabled with SSL I need to send the certificates and keys to Docker container.
the proposal is to create an |
...postgres/src/main/java/io/airbyte/integrations/destination/postgres/PostgresDestination.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-postgres/src/main/resources/spec.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good % the few small remaining comments.
...rs/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
@jrhizor I added the Dockerfile and script to generate SSL credentials inside Is OK to merge only Postgres for now? I'll divide and conquer the others with individual issues/PR to be easy to discuss implementations. |
...postgres/src/main/java/io/airbyte/integrations/destination/postgres/PostgresDestination.java
Show resolved
Hide resolved
amazing, thanks @marcosmarxm !! 🎉 |
What
Enable SSL connection. Resolves #1806
Source RedshiftHow
Add spec SSL and edit JDBC URL to request SSL
Pre-merge Checklist
Recommended reading order
test.java
component.ts