Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused schema parameter and cleanup. #2780

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Remove unused schema parameter and cleanup. #2780

merged 3 commits into from
Apr 7, 2021

Conversation

davinchia
Copy link
Contributor

What

Remove unused schema parameter for better readability.

Pre-merge Checklist

  • Run integration tests

@auto-assign auto-assign bot requested review from jrhizor and sherifnada April 7, 2021 10:08
@davinchia davinchia requested review from ChristopheDuong and removed request for jrhizor and sherifnada April 7, 2021 10:08
@davinchia
Copy link
Contributor Author

davinchia commented Apr 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/725667357
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/725667357

@davinchia
Copy link
Contributor Author

davinchia commented Apr 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/725668043
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/725668043

@davinchia
Copy link
Contributor Author

davinchia commented Apr 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/725668224
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/725668224

@davinchia
Copy link
Contributor Author

davinchia commented Apr 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-jdbc

🕑 connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/725668726
✅ connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/725668726

@davinchia
Copy link
Contributor Author

davinchia commented Apr 7, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-redshift

🕑 connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/725670169
✅ connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/725670169

ChristopheDuong
ChristopheDuong reviewed Apr 7, 2021
View reviewed changes
...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java
private List<TableInfoInternal> discoverInternal(final JdbcDatabase database,
final Optional<String> databaseOptional,
final Optional<String> schemaOptional)
private List<TableInfoInternal> discoverInternal(final JdbcDatabase database, final Optional<String> databaseOptional)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this databaseOptional is not unused as the schema parameter too? (depending on the source database, we sometimes use it as a schema replacement)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may be right. Will take a second look after!

@davinchia davinchia merged commit a7b9cd5 into master Apr 7, 2021
@davinchia davinchia deleted the davinchia/remove-unused-schema-params branch April 7, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheDuong ChristopheDuong ChristopheDuong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davinchia @ChristopheDuong