connectors-ci: make unhandled error lead to failed report #28789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
force-pushed
the
augustin/connectors-ci/better-error-handling-reporting
branch
from
f618bed
to
26b9f06
Compare
octavia-squidington-iii
added
area/connectors
|
| Step | Result |
|---|
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-openweather testThis reverts commit 26b9f06.
pedroslopez
approved these changes
Aug 1, 2023
| @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api" | |||
|
|
|||
| [tool.poetry] | |||
| name = "pipelines" | |||
| version = "0.1.0" | |||
| version = "0.1.1" | |||
There was a problem hiding this comment.
I think you'll have to bump this one again :)
alafanechere
deleted the
augustin/connectors-ci/better-error-handling-reporting
branch
bnchrch
pushed a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #27425
How
When an unhandled exception is bubbled up to the context
__aexit__we generate an empty report.The empty report was considered successful as they did not have fail steps.
We change this rule to consider a report successful if it has no failed step result and at least one successful or skipped step result.