-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectors-ci: make unhandled error lead to failed report #28789
connectors-ci: make unhandled error lead to failed report #28789
Conversation
f618bed
to
26b9f06
Compare
source-openweather test report (commit
|
Step | Result |
---|
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-openweather test
This reverts commit 26b9f06.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api" | |||
|
|||
[tool.poetry] | |||
name = "pipelines" | |||
version = "0.1.0" | |||
version = "0.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll have to bump this one again :)
What
Closes #27425
How
When an unhandled exception is bubbled up to the context
__aexit__
we generate an empty report.The empty report was considered successful as they did not have fail steps.
We change this rule to consider a report successful if it has no failed step result and at least one successful or skipped step result.