Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: fix airbyte-ci test run #28907

Merged
merged 13 commits into from
Aug 1, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Aug 1, 2023

What

Closes #28426
Fix the airbyte-ci tests we run in the airbyte-ci-test.yml GHA workflow

How

  • Skip failing publish test that are stale
  • Pass the docker host socket to the pytest container to enable dagger-in-dagger
  • Fix the path wildcard to correctly trigger the tests on PR
  • Remove superfluous fixture from test_publish.py

@alafanechere alafanechere marked this pull request as ready for review August 1, 2023 10:47
@alafanechere alafanechere changed the base branch from master to 10730-redshiftJDBParameter August 1, 2023 10:55
@alafanechere alafanechere requested review from a team as code owners August 1, 2023 10:55
@alafanechere alafanechere changed the base branch from 10730-redshiftJDBParameter to master August 1, 2023 10:56
@alafanechere alafanechere changed the title Augustin/connectors ci/fix test workflow connectors-ci: fix airbyte-ci test run Aug 1, 2023
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="fixing test run orchestration for airbyte-ci, not on the critical path"

@octavia-approvington
Copy link
Contributor

This is really good
simply the best

@octavia-approvington octavia-approvington merged commit b4606ca into master Aug 1, 2023
4 checks passed
@octavia-approvington octavia-approvington deleted the augustin/connectors-ci/fix-test-workflow branch August 1, 2023 11:04
bnchrch pushed a commit that referenced this pull request Aug 3, 2023
* enable workflow dispatch on test workflow

* install curl

* exit with 1 status code if exec error

* use click Abort

* fix wildcard

* remove superfluous fixtures

* skip failing publish tests

* share the docker socket with the testing container for dagger-in-dagger

* bump version

* bump version

* set workflow concurrency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Pipeline Unit tests run on Pipeline change
2 participants