Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Retently: Migrate Python CDK to Low-code CDK #29040

Closed

Conversation

avirajsingh7
Copy link
Contributor

@avirajsingh7 avirajsingh7 commented Aug 3, 2023

What

Migrating Source retently to Low-Code CDK
Closes #28118

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. manifest.yaml
  2. schemas/*

Test

Acceptance Test Screenshot 2023-08-03 at 6 52 13 PM

🚨 User Impact 🚨

No breaking changes, migration to low-code

Migrate Connector : Source retently
  • Community Member? Grant Edit Access to Maintainers instructions
  • Secrets in the Connector's Spec
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors::integrationTest.
  • Code Reviews Completed
    • Documentation Updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations//.md (including changelog. See changelog example)
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR Name follows PR Naming Conventions

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 3, 2023
@sajarin
Copy link
Contributor

sajarin commented Aug 7, 2023

Thanks for the contribution! Can you resolve the merge conflict @avirajsingh7?

@avirajsingh7
Copy link
Contributor Author

@sajarin sorry of that, resolved now

Copy link
Contributor

@sajarin sajarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some minor comments after running tests locally

Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
Signed-off-by: Aviraj Gour <100823015+avirajsingh7@users.noreply.github.com>
@avirajsingh7
Copy link
Contributor Author

@sajarin can you check now?

@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Aug 8, 2023
@sajarin
Copy link
Contributor

sajarin commented Aug 8, 2023

Thanks for the PR @avirajsingh7! This has been merged and tested in #29164. The reason why I wasn't able to merge this PR was because I needed to push some changes and run them against our CI but couldn't push to your branch since I didn't have branch permissions. Nevertheless, I forked your changes and tested in the PR aforementioned.

I'm closing this PR but this should still count for the hackathon of course. fyi @RealChrisSean

@sajarin sajarin closed this Aug 8, 2023
@avirajsingh7
Copy link
Contributor Author

thanks @sajarin

@avirajsingh7 avirajsingh7 mentioned this pull request Aug 9, 2023
@marcosmarxm marcosmarxm added the Hackathon External low-code/ui connector builder hackathons label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/retently Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Retently
4 participants