🎉 Source Google Adwords: support selecting the lookback window for determining conversions #2918
Conversation
There was a problem hiding this comment.
@harshithmullapudi Thanks for the contribution!! we will also need to pass this input to the singer tap in source.py. Would you like to make that change?
| @@ -10,7 +10,8 @@ | |||
| "oauth_client_secret", | |||
| "refresh_token", | |||
| "start_date", | |||
| "customer_ids" | |||
| "customer_ids", | |||
| "conversion_window_days" | |||
There was a problem hiding this comment.
this should not be a required parameter for backwards compatibility
There was a problem hiding this comment.
Backward compatibility apart, should it be required?
There was a problem hiding this comment.
nope. It should be optional. It basically decides the lookback window for getting reports. By default this is 30 days, but it should be configurable by the user
There was a problem hiding this comment.
Yeah I will remove from required
...-integrations/connectors/source-google-adwords-singer/source_google_adwords_singer/spec.json
Show resolved
Hide resolved
Yeah will work on that |
I think this is already taken care. As this comes from config.json. I did test this. |
There was a problem hiding this comment.
@harshithmullapudi looks great, and you are right about source.py -- my mistake for the misleading comment. Thanks!
sherifnada
changed the title
|
@harshithmullapudi FYI this is blocked on #2929 -- we're working on that this week and you should be able to access the new connector version once that issue is blocked. |
|
Thank you @harshithmullapudi !!! |
What
Describe what the change is solving
It helps the user to define the historical replication start date
How
Describe the solution
As the singer already supports it adding it in the schema will let airbyte api configure it