Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Santa: Oauth #3000

Merged
merged 17 commits into from
Apr 23, 2021
Merged

Santa: Oauth #3000

merged 17 commits into from
Apr 23, 2021

Conversation

sherifnada
Copy link
Contributor

No description provided.

@davinchia
Copy link
Contributor

davinchia commented Apr 21, 2021

@sherifnada this is how far I got today.

in summary:
1) able to get a refresh token from MS. checked into the token and a script to retrieve future tokens.
2) able to refresh the refresh token and get an access token via the bing sdk.
3) stuck on trying to make a call. this underlying protocol is SOAP (yuck) so I'm slowly working my way through it. full disclosure, I ended up working off the Bing python SDK examples. i found that the best way to understand what was going on since the docs weren't great. however, unsurprisingly, the examples don't work out of the box..

one question I had: it seems like the Bing api will requires a developer token? does other apis also need this?

excuse the messy code, I was coding fast and dirty. all the interesting stuff is in main_dev.py. everything else is scaffolding set up.

I do think we can get a working OAuth framework out by tmrw!

EDIT: we decided Bing is out of scope because of SOAP. Work is saved in the davinchia/checkpoint-bing-ads branch.

@davinchia
Copy link
Contributor

davinchia commented Apr 22, 2021

@sherifnada Implemented a super basic version of the Gmail API with Santa + OAuth and it works! I'm 90% convinced we should run with this version of OAuth now. I did not get to HubSpot since I could not find the willpower to retrieve a Hubspot refresh token after retrieving the Google one + reading all the HubSpot code..

I left a comparison Google SDK implementation for comparison. Pretty similar LOC, although ours is more readable. Honestly the most annoying thing so far is retrieving the initial refresh token.

Wrote down a summary of thoughts here.

@sherifnada sherifnada marked this pull request as ready for review April 23, 2021 00:05
@sherifnada sherifnada changed the title oauth skeleton Santa: Oauth Apr 23, 2021
@sherifnada
Copy link
Contributor Author

@davinchia this should be ready for review/merge. Updated base-python version. Moved gmail to sherif/santa-gmail-poc for historical reference if needed.

@davinchia
Copy link
Contributor

davinchia commented Apr 23, 2021

/publish connector=bases/base-python

🕑 bases/base-python https://github.com/airbytehq/airbyte/actions/runs/776249701
✅ bases/base-python https://github.com/airbytehq/airbyte/actions/runs/776249701

@davinchia davinchia merged commit 3827235 into master Apr 23, 2021
@davinchia davinchia deleted the sherif/santa-oauth branch April 23, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants