Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AlloyDB phase 2: Remove entirely #31145

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

evantahler
Copy link
Contributor

After #31144, now we've published the registry one last time, we can delete the directory

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Oct 6, 2023 9:47pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 6, 2023
@evantahler evantahler requested a review from a team October 6, 2023 21:47
@evantahler evantahler marked this pull request as ready for review October 6, 2023 21:48
@evantahler evantahler requested a review from a team as a code owner October 6, 2023 21:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now THIS is what we like to see

@evantahler
Copy link
Contributor Author

evantahler commented Oct 6, 2023

The connector has been tombstoned in the prod DB 🪦

@evantahler evantahler merged commit e3e231e into master Oct 6, 2023
32 of 36 checks passed
@evantahler evantahler deleted the evan/no-more-alloydb-2 branch October 6, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants